Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 66-mongodb.js #820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update 66-mongodb.js #820

wants to merge 1 commit into from

Conversation

dodois
Copy link

@dodois dodois commented Jul 20, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)

Proposed changes

Call done when the operation is complete

Checklist

  • [ x ] I have read the contribution guidelines
  • [ x ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • [ x ] I have run grunt to verify the unit tests pass
  • [ ] I have added suitable unit tests to cover the new/changed functionality

Call done when the operation is complete
@dceejay
Copy link
Member

dceejay commented Jul 20, 2021

Hi @dodois

Useful update but as the done capability was added later - you need to check if it exists before calling it in case someone is running a very old version that doesn't pass it it.

eg see - https://github.com/node-red/node-red-nodes/blob/master/storage/mysql/68-mysql.js#L110
and
https://github.com/node-red/node-red-nodes/blob/master/storage/mysql/68-mysql.js#L110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants